Skip to content

Convert Attachment Object#360

Open
GeneCodeSavvy wants to merge 6 commits intodevelopfrom
feature/sbol_convertor_attachment_objects
Open

Convert Attachment Object#360
GeneCodeSavvy wants to merge 6 commits intodevelopfrom
feature/sbol_convertor_attachment_objects

Conversation

@GeneCodeSavvy
Copy link
Collaborator

@GeneCodeSavvy GeneCodeSavvy commented Aug 5, 2025 •
edited
Loading

This PR closes #244

I have not pushed the tests. They will fail due to #359
I will push the tests, once the mentioned PR is merged, fixing the backport issue

@jakebeal
Copy link
Contributor

jakebeal commented Aug 18, 2025

This is looking good to me; holding off on formally approving until #359 is resolved and the tests are pushed.

Gonza10V
Gonza10V approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@Gonza10V Gonza10V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi This looks good to me too, @jakebeal please merge when you aprrove it. Now #359 is merged so this should follow.

jakebeal
jakebeal requested changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@jakebeal jakebeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#359 may be merged, but this cannot be merged until it has tests added. @GeneCodeSavvy , can you please push the tests?

@GeneCodeSavvy GeneCodeSavvy force-pushed the feature/sbol_convertor_attachment_objects branch from 292e7fc to 5d1b062 Compare October 21, 2025 16:20
@GeneCodeSavvy
Copy link
Collaborator Author

GeneCodeSavvy commented Oct 22, 2025

tests are failing due to unrelated errors

FAILED test/test_calculate_sequences.py::TestCalculateSequences::test_calculate_sequences - urllib.error.HTTPError: HTTP Error 503: Service Unavailable
FAILED test/test_calculate_sequences.py::TestCalculateSequences::test_circular_calculation - urllib.error.HTTPError: HTTP Error 503: Service Unavailable
= 2 failed, 78 passed, 1 skipped, 1 xfailed, 1001 warnings in 82.88s (0:01:22) =

@jakebeal
Copy link
Contributor

jakebeal commented Oct 23, 2025

Re-running the failing tests gets past the rate-limits on the external services.
I've filed #368 for preventing these types of rate-limiting failures.

jakebeal
jakebeal requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@jakebeal jakebeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see test files, but not yet a test that actually makes use of them.

@GeneCodeSavvy
Copy link
Collaborator Author

GeneCodeSavvy commented Oct 25, 2025 •
edited
Loading

I see test files, but not yet a test that actually makes use of them.

yep, i was waiting for some clarity about the tests. I have added the tests now

@GeneCodeSavvy GeneCodeSavvy force-pushed the feature/sbol_convertor_attachment_objects branch from c40da2a to 8bed8ce Compare October 25, 2025 19:24
@GeneCodeSavvy
Copy link
Collaborator Author

GeneCodeSavvy commented Oct 25, 2025

@jakebeal the test are passing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gonza10V Gonza10V Gonza10V approved these changes

@jakebeal jakebeal Awaiting requested review from jakebeal

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SBOL 2-3 converter - Attachment (Priority 2)

3 participants

@GeneCodeSavvy @jakebeal @Gonza10V